Adopt special review process officially #1347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are occassionally PRs that improve CDT in areas where there is not enough current Eclipse CDT committer experience to provide detailed reviews. Therefore the Eclipse CDT project adopted (in [Oct 2023 call](https://hackmd.io/@jonahgraham/cdt-call-october-11-2023) and reaffirmed in [Oct 2025 call](eclipse-cdt#1340)) that such if the code looks correct and it is sufficiently tested it is ok to accept these changes. Examples of previous times this policy has been adopted include [PR eclipse-cdt#587](eclipse-cdt#587 (comment)), [PR eclipse-cdt#581](eclipse-cdt#581 (review)) and others, particularly in the [language support category](https://github.com/eclipse-cdt/cdt/pulls?q=is%3Apr+is%3Aclosed+label%3Alanguage+). This policy can be referenced by a CDT committer/reviewer in the approval process.
Member
Author
|
I have added this to the call agenda today in #1340 There are a number of high-quality outstanding PRs from @i-garrison and @davmac314 that I would like to merge, but I think we should reaffirm the policy that was first floated in 2023. |
jonahgraham
added
documentation
Member
Author
|
I think #754 may fall under this policy too? |
Member
Author
|
Discussed and reviewed during the CDT call and no objections raised to reaffirm this. #1340 (comment) Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are occassionally PRs that improve CDT in areas where there is not enough current Eclipse CDT committer experience to provide detailed reviews. Therefore the Eclipse CDT project adopted (in Oct 2023 call and reaffirmed in Oct 2025 call) that such if the code looks correct and it is sufficiently tested it is ok to accept these changes.
Examples of previous times this policy has been adopted include PR #587, PR #581 and others, particularly in the
language support category.
This policy can be referenced by a CDT committer/reviewer in the approval process.